fix: convert numpy types to Python native in predictions#406
Open
Abiram08 wants to merge 2 commits intosktime:mainfrom
Open
fix: convert numpy types to Python native in predictions#406Abiram08 wants to merge 2 commits intosktime:mainfrom
Abiram08 wants to merge 2 commits intosktime:mainfrom
Conversation
This was referenced Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #401
What does this implement/fix? Explain your changes.
Fixes an issue where fit_predict returned
numpy.float64values, which caused JSON serialization failures in MCP responses.Changes in executor.py:
pd.Series: Convert values usingfloat(v) if hasattr(v, "dtype")pd.DataFrame: Convert nested values with list comprehensionhasattr(v, "dtype")to detect numpy types without importing numpyDoes your contribution introduce a new dependency?
No.
What should a reviewer concentrate their feedback on?
hasattr(v, "dtype")is the right approach for detecting numpy typesfloat()conversion handles all edge cases correctlyAny other comments?
Added test_numpy_serialization.py verifying predictions are JSON serializable.
PR checklist